Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon and logo #70

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Update favicon and logo #70

merged 1 commit into from
Jun 1, 2023

Conversation

rjwills28
Copy link
Collaborator

I've updated the the favicon and logo based on the updated image provided in #54. As far as I can tell, the favicon already appears on the documentation webpage (see https://diamondlightsource.github.io/coniql/main/index.html), so nothing more to do there.

@aawdls
Copy link
Contributor

aawdls commented May 31, 2023

Does this get served at /favicon.ico for coniql.diamond.ac.uk or just for the docs?

@AlexanderWells-diamond
Copy link
Contributor

This will not get served in the main application. The image only exists in the docs/images directory and I don't think it ends up in the runtime image.

The only human-readable web endpoint Coniql really exposes is /ws, and that's only when we turn on Graphiql. I don't think we can actually modify that page, as it looks like the favicon is somehow baked in to the Javascript or CSS - at least, there's no explicit request to the server for the favicon.

I can see the appeal in including it in the actual application. I can also see that there's no real point in doing so, at least at present, as there will be no-one to view it.

Copy link
Contributor

@aawdls aawdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agree

@rjwills28 rjwills28 merged commit 3779a29 into main Jun 1, 2023
@rjwills28 rjwills28 mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants