Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added path-pattern-on-fails for screenshots (closes #7014) #8055

Merged
merged 7 commits into from
Dec 19, 2023
Merged

feat: Added path-pattern-on-fails for screenshots (closes #7014) #8055

merged 7 commits into from
Dec 19, 2023

Conversation

PavelMor25
Copy link
Collaborator

@PavelMor25 PavelMor25 commented Oct 25, 2023 •
edited
Loading

Approach

  • added support new configuration screenshot option

References

issue 7014

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 25, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 25, 2023 08:26 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 25, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 26, 2023 11:36 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 temporarily deployed to CI October 27, 2023 04:31 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 changed the title updated path-pattern for screenshots Added path-pattern-on-fails for screenshots Oct 27, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 27, 2023 06:04 — with GitHub Actions Inactive
Aleksey28
Aleksey28 requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, please, look at my comments.

src/utils/path-pattern.js Outdated Show resolved Hide resolved
src/utils/path-pattern.js Outdated Show resolved Hide resolved
src/utils/path-pattern.js Outdated Show resolved Hide resolved
src/utils/path-pattern.js Outdated Show resolved Hide resolved
src/runner/index.js Outdated Show resolved Hide resolved
src/runner/index.js Outdated Show resolved Hide resolved
@PavelMor25 PavelMor25 temporarily deployed to CI October 28, 2023 04:42 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 temporarily deployed to CI October 28, 2023 08:08 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 closed this Oct 28, 2023
@PavelMor25 PavelMor25 reopened this Oct 28, 2023
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 28, 2023
@PavelMor25 PavelMor25 temporarily deployed to CI October 28, 2023 08:08 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 29, 2023
Aleksey28
Aleksey28 requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

src/utils/path-pattern.js Outdated Show resolved Hide resolved
@PavelMor25 PavelMor25 temporarily deployed to CI October 31, 2023 04:37 — with GitHub Actions Inactive
@PavelMor25 PavelMor25 changed the title Added path-pattern-on-fails for screenshots Added path-pattern-on-fails for screenshots (closes #7014) Nov 13, 2023
@PavelMor25 PavelMor25 changed the title Added path-pattern-on-fails for screenshots (closes #7014) feat: Added path-pattern-on-fails for screenshots (closes #7014) Nov 13, 2023
@aleks-pro aleks-pro marked this pull request as ready for review November 14, 2023 12:58
Aleksey28
Aleksey28 requested changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase please, then merge when tests are green

@PavelMor25 PavelMor25 removed the request for review from aleks-pro December 14, 2023 10:15
@aleks-pro aleks-pro merged commit 51b54c7 into DevExpress:master Dec 19, 2023
20 checks passed
@github-actions GitHub Actions
Copy link

Release v3.5.0-rc.1 addresses this.

1 similar comment
@github-actions GitHub Actions
Copy link

Release v3.5.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksey28 Aleksey28 Aleksey28 approved these changes

Assignees
No one assigned
Labels
Awaiting documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PavelMor25 @Aleksey28 @aleks-pro