Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximizeWindow does not work on mac os 14.2.1 #8117

Closed
vasilyevi opened this issue Jan 11, 2024 · 20 comments · Fixed by #8135
Closed

maximizeWindow does not work on mac os 14.2.1 #8117

vasilyevi opened this issue Jan 11, 2024 · 20 comments · Fixed by #8135
Assignees
Labels
TYPE: bug The described behavior is considered as wrong (bug).

Comments

@vasilyevi
Copy link

What is your Scenario?

t.maximizeWindow()

What is the Current behavior?

does not work

What is the Expected behavior?

window have to be maximized

What is the public URL of the test page? (attach your complete example)

N/A

What is your TestCafe test code?

t.maximizeWindow()

Your complete configuration file

No response

Your complete test report

No response

Screenshots

No response

Steps to Reproduce

t.maximizeWindow()

TestCafe version

3.5.0

Node.js version

v18.17.0

Command-line arguments

npx testcafe

Browser name(s) and version(s)

No response

Platform(s) and version(s)

No response

Other

Could you add unit tests it's not a first time

@vasilyevi vasilyevi added the TYPE: bug The described behavior is considered as wrong (bug). label Jan 11, 2024
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 11, 2024
@PavelMor25 PavelMor25 assigned PavelMor25 and unassigned PavelMor25 Jan 15, 2024
@PavelMor25
Copy link
Collaborator

Hello @vasilyevi ,

I can't reproduce the issue on macOS 10.15.7 and 13.6.3 with TestCafe v3.5.0.

Regarding the tests, they're available for the entire main API, including maximizeWindow.

@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 18, 2024
@vasilyevi
Copy link
Author

10.15.7?
Im using Sonoma 14.2.1 (23C71)

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 18, 2024
@PavelMor25
Copy link
Collaborator

Hello,
I attempted to run the test with the maximizeWindow() method on Sonoma 14.12.1 (Chrome 120.0.0 / Safari 17.2) and observed the expected behavior. Currently, we cannot determine the issue. If you have any information that can help us reproduce the issue, please share it.

photo1705901661

@PavelMor25 PavelMor25 added STATE: Need clarification An issue lacks information for further research. and removed STATE: Need response An issue that requires a response or attention from the team. labels Jan 22, 2024
@vasilyevi
Copy link
Author

did you try chrome headed mode?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 22, 2024
@github-actions github-actions bot removed the STATE: Need clarification An issue lacks information for further research. label Jan 22, 2024
@AlekseyKravtsov17
Copy link

I have the same issue on windows 10 with TestCafe v3.5.0

@vasilyevi
Copy link
Author

@PavelMor25 try with headed mode.
I use the same chrome Chrome 120.0.0.0 / Sonoma 14
maybe node version is also important? my is v18.17.0

@PavelMor25
Copy link
Collaborator

@vasilyevi, I tried to reproduce it in Chrome 120.0.0.0 / Sonoma 14 / Node v18.17.1 in both headed and headless modes. Everything works as expected. Could you record the entire test run process? It might help us investigate the issue.

@AlekseyKravtsov17, could you please specify the browser in which you encounter the issue and the version of Node.js you are using?

@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 24, 2024
@AlekseyKravtsov17
Copy link

@PavelMor25 I also use Chrome 120.0.0.0 and Node v16.17.0

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 24, 2024
@vasilyevi
Copy link
Author

maximizeWindow.zip
npm install
npx testcafe

Try it out

@vasilyevi
Copy link
Author

@PavelMor25

@vasilyevi
Copy link
Author

Give me the email where I can send the recording

@PavelMor25
Copy link
Collaborator

Hello @vasilyevi, I was able to reproduce the issue from your example.

For the team: Some test controller methods don't work in the beforeEach fixture hook.

@AlekseyKravtsov17, are you also using maximizeWindow in the beforeEach fixture hook?

@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 25, 2024
@AlekseyKravtsov17
Copy link

@PavelMor25 yes, I have the same test scenario as @vasilyevi

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 25, 2024
@aleks-pro aleks-pro removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 25, 2024
@vasilyevi
Copy link
Author

@PavelMor25 please add tests on that also. When we can expect a fix?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 25, 2024
@PavelMor25
Copy link
Collaborator

Hello @vasilyevi,
We add a test for each fix or new functionality. We are working on this issue. However, we cannot give you any estimates on when the issue is fixed.

@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 30, 2024
@PavelMor25 PavelMor25 self-assigned this Jan 31, 2024
@Raydir
Copy link

Raydir commented Feb 8, 2024

same here with resize - glad you found it already :D

Package.json
testcafe chrome tests/TEST-Basics_000.ts --disable-multiple-windows --native-automation

Tested with Win11 / TestCafé 3.3.0 / 3.5.0 --> nok

Worked smootly with TestCafé 2.6.2

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Feb 8, 2024
@PavelMor25
Copy link
Collaborator

Hello @Raydir,

Thank you for sharing this information. If your usage scenario is different, please share a minimal working example with us.

@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Feb 12, 2024
@Raydir
Copy link

Raydir commented Feb 12, 2024

hm.. i had the same behaviour in beforeEach with Testcafe 3.5.0
For me "resize" and "maximize" did not work.

However:
I deleted all nodemodules and package-lock.json and after reinstalling 3.5.0 new and now it does work again for me.

Sorry for the missing minimal working example.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Feb 12, 2024
@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Feb 15, 2024
PavelMor25 added a commit that referenced this issue Feb 16, 2024
…in NA mode (#8135)

<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose


## Approach


## References
closes #8117 

## Pre-Merge TODO
- [ ] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail
@vasilyevi
Copy link
Author

Are you going to release the fix?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 15, 2024
@Bayheck
Copy link
Collaborator

Bayheck commented Mar 18, 2024

Hello,

We cannot give you an ETA for when we will release this fix. Hopefully, it will be in the next TestCafe release.

@Bayheck Bayheck removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants