Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateDirectory: use /sbin/mount on macOS #1162

Merged
merged 2 commits into from
Sep 11, 2024
Merged

CreateDirectory: use /sbin/mount on macOS #1162

merged 2 commits into from
Sep 11, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Sep 11, 2024

Some users report mount not being found in PATH when using
Terminal.app (even though I can't reproduce this).

Description

Closes #1021.
Closes #1160.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Some users report `mount` not being found in PATH when using
Terminal.app (even though I can't reproduce this).
@cole-h cole-h added this to the 0.26.0 milestone Sep 11, 2024
@cole-h cole-h enabled auto-merge (squash) September 11, 2024 19:17
@cole-h cole-h merged commit 24116bc into main Sep 11, 2024
21 checks passed
@cole-h cole-h deleted the macos-mount-command branch September 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants