Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fixup socket enablement on older systemd versions #1095

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Properly fixup socket enablement on older systemd versions #1095

merged 2 commits into from
Aug 16, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Aug 16, 2024

I completely ignored the other branch of the if, oops.

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@cole-h cole-h enabled auto-merge (squash) August 16, 2024 23:38
grahamc
grahamc approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@cole-h cole-h merged commit 9010178 into main Aug 16, 2024
20 checks passed
@cole-h cole-h deleted the fixup-systemd-socket-enablement branch August 16, 2024 23:54
@cole-h cole-h added this to the 0.21.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-h @grahamc