Use collectibles for displayProperties on redacted items #3427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most redacted items have Collectibles that are not redacted. This PR uses them for displayProperties of name, icon and description where they can be used. It still doesn't let us equip the item or determine its power, but at least the item is now searchable and provides a bit more context.
I also had to make a change to LazyDefinition to support getting all definitions of a type (because I need to key Collectibles by itemHash). I hope this is okay and I've done it correctly 😇