Remove gitattributes #224
Merged
Remove gitattributes #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #100 we removed the generated files an publish them via GitHub pages. Since then we've added a custom src/scanner.c file that is being treated as a generated file on GitHub due to the .gitattributes file. Since it's no longer needed, I've removing it.
dmfay
approved these changes
Nov 10, 2023
|
I am curious why the python import error occurs on the macos test runner? |
DerekStride
force-pushed
the
scanner-not-generated
branch
from
9658afa
to
589436f
Compare
That got resolved when I updated the node version for some reason and there was another bug with the nan package seemed to be fixed by updating the dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #100 we removed the generated files an publish them via GitHub pages. Since then we've added a custom src/scanner.c file that is being treated as a generated file on GitHub due to the .gitattributes file. Since it's no longer needed, I've removing it.