Add missing scanner.c to README and Package.swift #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a new scanner.c source file had been added to the repository. The Makefile had been updated, but the command in the README was missing the new file. This change adds the new file to the command in the README, and also updates the Package.swift file to declare it as a source.
leamingrad
commented
Nov 8, 2023
| @@ -26,6 +26,7 @@ let package = Package( | |||
| ], | |||
| sources: [ | |||
| "src/parser.c", | |||
| "src/scanner.c", | |||
There was a problem hiding this comment.
I don't know anything about swift, so I am not sure whether this change is correct/how to test it (but I am happy to have a go if others can explain what I need to do).
There was a problem hiding this comment.
I'm unsure as well but I suspect this is all that's needed.
cc// @mattmassicotte let us know if there's anything else that's needed
There was a problem hiding this comment.
This looks good - thanks for keeping it up to date!
DerekStride
approved these changes
Nov 9, 2023
| @@ -26,6 +26,7 @@ let package = Package( | |||
| ], | |||
| sources: [ | |||
| "src/parser.c", | |||
| "src/scanner.c", | |||
There was a problem hiding this comment.
I'm unsure as well but I suspect this is all that's needed.
cc// @mattmassicotte let us know if there's anything else that's needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a new scanner.c source file had been added to the repository. The Makefile had been updated, but the command in the README was missing the new file.
This change adds the new file to the command in the README, and also updates the Package.swift file to declare it as a source.
I think this PR is just a bugfix following from #203.