Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Trivy DB for integration tests #4181

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 26, 2024

Description

Caches Trivy DB for integration tests.

Trivy integration tests are failing in CI more frequently now, mostly because the Trivy container keeps downloading its vulnerability from ghcr.io, and the registry enforces rate limiting.

Cache the database between tests to prevent redundant downloads.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Trivy integration tests are failing in CI more frequently now, mostly because the Trivy container keeps downloading its vulnerability from ghcr.io, and the registry enforces rate limiting.

Cache the database between tests to prevent redundant downloads.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the defect Something isn't working label Sep 26, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 26, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 189dd2d1 (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (189dd2d) Report Missing Report Missing Report Missing
Head commit (b32cffa) 22138 17499 79.05%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4181) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@nscuro nscuro merged commit 35f18c4 into DependencyTrack:master Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant