Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix that Emails render all symbols right #4141

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

Gepardgame
Copy link
Contributor

Description

Fixes that emails can render all symbols right:
image

Addressed Issue

Fixes #4140

Additional Details

Changed MIME Type to include chaset=utf-8, so it uses utf-8 and not just ASCII.
Unescapse the content, so e.g. & does not convert to & and other such things.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
    - [ ] This PR implements an enhancement, and I have provided tests to verify that it works as intended
    - [ ] This PR introduces changes to the database model, and I have added corresponding update logic
    - [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Copy link

codacy-production bot commented Sep 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (237ba91) 21956 17319 78.88%
Head commit (014ec6c) 21957 (+1) 17320 (+1) 78.88% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4141) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Could you add a test to SendMailPublisherTest that includes special characters, to verify the escaping works as expected?

@nscuro nscuro added the defect Something isn't working label Sep 22, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 22, 2024
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
@Gepardgame
Copy link
Contributor Author

I don't know why the test fails, locally it runs completely fine.

@nscuro
Copy link
Member

nscuro commented Sep 23, 2024

Maybe flaky, haven't seen that test fail before but could always be. Restarted the test workflow.

@nscuro nscuro merged commit 8044252 into DependencyTrack:master Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emails don't render certain things right
2 participants