Support assigning of teams for portfolio ACL when creating a project #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
requested changes
Aug 24, 2024
src/main/java/org/dependencytrack/resources/v1/TeamResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/TeamResource.java
Outdated
Show resolved
Hide resolved
Gepardgame
force-pushed
the
feat/add-team-selection-in-create-proect-button
branch
from
a9f950f
to
12c72d4
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Gepardgame
commented
Sep 2, 2024
src/main/java/org/dependencytrack/resources/v1/TeamResource.java
Outdated
Show resolved
Hide resolved
Gepardgame
force-pushed
the
feat/add-team-selection-in-create-proect-button
branch
from
7ffc4ee
to
fc26e7a
Compare
Gepardgame
force-pushed
the
feat/add-team-selection-in-create-proect-button
branch
from
fc26e7a
to
7ce8e04
Compare
…Team is given to the project Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
…-create-proect-button
|
@nscuro Is there a chance that will get into 4.12, we would love to use it. |
nscuro
requested changes
Sep 18, 2024
src/test/java/org/dependencytrack/resources/v1/ProjectResourceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/dependencytrack/resources/v1/ProjectResourceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/dependencytrack/resources/v1/ProjectResourceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/dependencytrack/resources/v1/ProjectResourceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/ProjectResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/TeamResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/TeamResource.java
Outdated
Show resolved
Hide resolved
…-create-proect-button
…-create-proect-button
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
…hub.com:Gepardgame/dependency-track into feat/add-team-selection-in-create-proect-button
tests Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
…-create-proect-button
nscuro
approved these changes
Sep 24, 2024
nscuro
added a commit
to nscuro/dependency-track
that referenced
this pull request
Sep 28, 2024
With DependencyTrack#4093, the `accessTeams` field became a required request parameter if portfolio ACL is enabled. While it does make sense to enforce team assignment, it is a breaking change in the REST API and as such cannot be done in a minor version release. Make `accessTeams` optional. Also: * Enable `accessTeams` to be specified by `name`, not only by `uuid` * Document this feature in the OpenAPI spec * Reduce nesting in the `ProjectResource#createProject` method * Enhance tests to be more explicit and assert response content Signed-off-by: nscuro <nscuro@protonmail.com>
2 tasks
nscuro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a option to the Create Project dialog to add a team
Added API endpoint to get available Teams. Also needed to create two new classes, for returning.
Altered create Project API Point, to be able to also add a initial Team to the project.
Addressed Issue
Fixes #4092
Checklist
- [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective- [ ] This PR introduces changes to the database model, and I have added corresponding update logic- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly