Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance badge API to require authorization #4059

Commits on Sep 11, 2024

  1. Change badges access from checkbox to permission

    Replace enabling of unauthenticaed access to badges via admin config
    checkbox with an api authentication with a new dedicated permission
    "VIEW_BADGES".
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    002c6f4 View commit details
    Browse the repository at this point in the history
  2. Add ACL awareness to badges

    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f7cdc28 View commit details
    Browse the repository at this point in the history
  3. Remove config property constant for badge enabling

    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    309dc39 View commit details
    Browse the repository at this point in the history
  4. Modify tests to accomodate badge changes

    Add new badge permission to tests. Remove tests for badge disabling. Add
    tests testing authentication, permission and ACL access.
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d1067c2 View commit details
    Browse the repository at this point in the history
  5. Update documentation

    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1931654 View commit details
    Browse the repository at this point in the history
  6. Enable auth via URI query param for badge API

    Allows API authentication via URI query param for badge requests as an
    alternative to header authentication because typical use cases for
    badges do not easily allow header injection.
    
    Requires stevespringett/Alpine#641
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    60ffaaf View commit details
    Browse the repository at this point in the history
  7. Update badge resource tests to auth via URI query

    Update tests to focus on API authentication via URI query parameter, but
    keep some tests that test header authentication as that remains an
    option.
    
    Requires  stevespringett/Alpine#641
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8c40c9a View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Add default team for badges

    Add a default team for viewing badges for new DBs.
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0e3e576 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Resurrect enable badges setting for deprecation

    To make the removal of unauthenticated access to badges not be a
    breaking change after all, the enable badges config property is kept in
    after all, but repurposed into a setting to enable unauthenticated
    access to the badges resource. If it is disabled, then the badges api
    remains accessible to authenticated and authorized requests.
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4665b53 View commit details
    Browse the repository at this point in the history
  2. Add tests for enabled unauthenticated badge access

    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f265b35 View commit details
    Browse the repository at this point in the history
  3. Update documentation

    Update documentation for globally configurable unauthenticated access to
    badges.
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    02a44ac View commit details
    Browse the repository at this point in the history
  4. Fix tests to take into account new default team

    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    efb2504 View commit details
    Browse the repository at this point in the history