Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support authentication for public / non-internal repositories #2876

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Support authentication for public / non-internal repositories #2876

merged 10 commits into from
Nov 14, 2023

Conversation

mehab
Copy link
Contributor

@mehab mehab commented Jul 6, 2023 •
edited by nscuro
Loading

Description

Addressed Issue

Closes #2870

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

mehab added 2 commits July 6, 2023 15:31
@mehab
added changes for global authentication
c7e8877 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab
added default value for password in repository update part
0a47981 
Signed-off-by: mehab <meha.bhargava@citi.com>
@nscuro nscuro added this to the 4.10 milestone Jul 8, 2023
@melba-lopez melba-lopez added the enhancement New feature or request label Jul 28, 2023
@nscuro nscuro added the needs milestone Issues or PRs that are pending a milestone assignment label Oct 26, 2023
@nscuro nscuro removed this from the 4.10 milestone Oct 26, 2023
@nscuro nscuro added this to the 4.10 milestone Nov 6, 2023
@nscuro nscuro removed the needs milestone Issues or PRs that are pending a milestone assignment label Nov 6, 2023
mehab and others added 2 commits November 6, 2023 17:56
@mehab mehab requested a review from nscuro November 6, 2023 18:23
@mehab
added changes for universal auth in repometaanalysistask
a47fd35 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab
using authrequired field to set credentials
56342dc 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab
pr fixes
991fe10 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab @nscuro
Update src/main/java/org/dependencytrack/tasks/repositories/Repositor…
8f3eba0 
…yMetaAnalyzerTask.java

Co-authored-by: Niklas <nscuro@protonmail.com>
Signed-off-by: meha <meha.bhargava2@gmail.com>
@nscuro
Copy link
Member

nscuro commented Nov 13, 2023

Apologies @mehab, I created a merge conflict here by merging #3112 (which incidentally benefits from the changes you made here!). May I ask you to fix the conflicts one last time? Thanks!

@mehab
resolved merge conflicts
bdb7120 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab
Merge branch 'feature/addGlobalAuthentication' of https://github.com/…
d0191a7 
…mehab/dependency-track into feature/addGlobalAuthentication
@mehab mehab requested a review from nscuro November 14, 2023 15:14
@nscuro nscuro changed the title added changes for global authentication Support authentication for public / non-internal repositories Nov 14, 2023
@nscuro nscuro merged commit 58c1259 into DependencyTrack:master Nov 14, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nscuro nscuro Awaiting requested review from nscuro

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.10
Development

Successfully merging this pull request may close these issues.

Implement global authentication for repositories
3 participants
@mehab @nscuro @melba-lopez