Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Component Property API #2717

Closed
wants to merge 2 commits into from
Closed

Add Component Property API #2717

wants to merge 2 commits into from

Conversation

rkesters
Copy link
Contributor

@rkesters rkesters commented Apr 27, 2023 •
edited
Loading

Description

Added the same Property API to Components that exists for Projects as requested in #2715

Addressed Issue

closes #2715

Additional Details

  • Did not update the documentation as Project Property API did not appear to be documented.

  • Updated update logic by adding a marking updater to increase the schema version. If I did this wrong please let me know what I should have done.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Apr 27, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2717.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2717.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser. ↩

@rkesters rkesters marked this pull request as ready for review April 27, 2023 06:55
nscuro
nscuro requested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @rkesters! Few minor changes required.

cp.txt Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/model/ComponentProperty.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/persistence/ComponentQueryManager.java Show resolved Hide resolved
src/main/java/org/dependencytrack/resources/v1/ComponentPropertyResource.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/resources/v1/ComponentPropertyResource.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/resources/v1/ComponentPropertyResource.java Show resolved Hide resolved
src/main/java/org/dependencytrack/resources/v1/ComponentPropertyResource.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/resources/v1/ComponentPropertyResource.java Show resolved Hide resolved
src/main/java/org/dependencytrack/upgrade/v490/v490Updater.java Outdated Show resolved Hide resolved
@melba-lopez
Copy link
Contributor

@rkesters thanks for making these enhancements! Are you able to make the changes requested by @nscuro? Please make sure to update your branch as well 😄

@rkesters
Add Component Property API
0934d37 
Signed-off-by: Robert Kesterson <rkesters@gmail.com>
@rkesters
Updated for code review of PR 2717
2f14858 
Signed-off-by: Robert Kesterson <rkesters@gmail.com>
@rkesters
Copy link
Contributor Author

@rkesters thanks for making these enhancements! Are you able to make the changes requested by @nscuro? Please make sure to update your branch as well 😄

@melba-lopez I have responded to the comments and rebased the branch.

@nscuro nscuro mentioned this pull request Feb 26, 2024
Closed
2 tasks
nscuro added a commit to nscuro/dependency-track that referenced this pull request Feb 26, 2024
@nscuro @rkesters
Add component property model and resource
ffcdab9 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro mentioned this pull request Feb 26, 2024
Merged
2 tasks
nscuro added a commit to nscuro/dependency-track that referenced this pull request Mar 2, 2024
@nscuro @rkesters
Add component property model and resource
4f1ce16 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Mar 4, 2024
@nscuro @rkesters
Add component property model and resource
7db92db 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Mar 16, 2024
@nscuro @rkesters
Add component property model and resource
5c2a7e9 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Mar 26, 2024
@nscuro @rkesters
Add component property model and resource
10e9120 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Apr 1, 2024
@nscuro @rkesters
Add component property model and resource
61fdbf2 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Apr 8, 2024
@nscuro @rkesters
Add component property model and resource
9d6a272 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Apr 14, 2024
@nscuro @rkesters
Add component property model and resource
aa7b560 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Apr 14, 2024
@nscuro @rkesters
Add component property model and resource
1fbd88f 
Supersedes DependencyTrack#2717

Co-authored-by: Robert Kesterson <rkesters@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to nscuro/dependency-track that referenced this pull request Apr 14, 2024
@nscuro
Add @rkesters to release credits
523b5f0 
For his work on the component property feature in DependencyTrack#2717.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro closed this in #3499 Apr 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonatype-lift sonatype-lift sonatype-lift left review comments

@nscuro nscuro nscuro requested changes

Assignees
No one assigned
Labels
enhancement New feature or request pending more information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Properties to components API
3 participants
@rkesters @melba-lopez @nscuro