Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Improved clipboard copying code #262

Merged
merged 2 commits into from
Nov 16, 2023
Merged

refactor: Improved clipboard copying code #262

merged 2 commits into from
Nov 16, 2023

Conversation

neerajkumarc
Copy link
Contributor

Summary

Improved the clipboard code by replacing the deprecated document.execCommand with the modern Clipboard API (navigator.clipboard.writeText).

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

DenverCoder1
DenverCoder1 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Improved Clipboard Copying Code refactor: Improved clipboard copying code Nov 16, 2023
@DenverCoder1 DenverCoder1 merged commit dd8bcf7 into DenverCoder1:main Nov 16, 2023
2 checks passed
@neerajkumarc neerajkumarc deleted the improve-clipboard-code branch November 17, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neerajkumarc @DenverCoder1