Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example to README #245

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Added example to README #245

merged 1 commit into from
Sep 5, 2023

Conversation

BrunoOliveiraS
Copy link
Contributor

Summary

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

DenverCoder1
DenverCoder1 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I might recommend adjusting the width to be a bit wider (eg. 550 or so) since it seems one of the letters is cut off.

Screenshot_20230904-181040.png

@DenverCoder1 DenverCoder1 merged commit 4432efa into DenverCoder1:main Sep 5, 2023
2 checks passed
@BrunoOliveiraS
Copy link
Contributor Author

Looks good.

I might recommend adjusting the width to be a bit wider (eg. 550 or so) since it seems one of the letters is cut off.

Screenshot_20230904-181040.png

Sure, I've made the recommended change. Width is now set to 550. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoOliveiraS @DenverCoder1