Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added repeat option to disable loop #181

Merged
merged 7 commits into from
Dec 19, 2022
Merged

feat: Added repeat option to disable loop #181

merged 7 commits into from
Dec 19, 2022

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Dec 19, 2022 •
edited
Loading

Summary

Add repeat option defaulting to true.

repeat=true - current behavior, loop to beginning of animation when complete
repeat=false - leave the last line frozen in place when it is completed

Fixes #180

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Dec 19, 2022
@DenverCoder1 DenverCoder1 merged commit ebec94d into main Dec 19, 2022
@DenverCoder1 DenverCoder1 deleted the feat/repeat branch December 19, 2022 20:45
@DenverCoder1 DenverCoder1 mentioned this pull request Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option: do not reset while in multiline mode
1 participant
@DenverCoder1