Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/147/prettier workflow #152

Merged
merged 4 commits into from
Oct 16, 2022
Merged

Feat/147/prettier workflow #152

merged 4 commits into from
Oct 16, 2022

Conversation

Vyvy-vi
Copy link
Contributor

@Vyvy-vi Vyvy-vi commented Oct 15, 2022

Summary

This PR adds a prettier github actions workflow to lint/format the code.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

closes #147

DenverCoder1
DenverCoder1 approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Running composer format should resolve the checks (I could also probably merge it as is and hope the workflow does what it's supposed to).

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
DenverCoder1
DenverCoder1 reviewed Oct 16, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
Vyvy-vi
Vyvy-vi commented Oct 16, 2022
View reviewed changes
Copy link
Contributor Author

@Vyvy-vi Vyvy-vi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wupps, there's a typo

Vyvy-vi and others added 2 commits October 16, 2022 12:05
@Vyvy-vi @DenverCoder1
Apply suggestions from code review
7e3ce7b 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@DenverCoder1
style: mark faq html to not format
4565732
DenverCoder1
DenverCoder1 approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks 👍

I think it's good to merge since hopefully the workflow will fix the formatting automatically. 🤞

@DenverCoder1 DenverCoder1 merged commit 9581c33 into DenverCoder1:main Oct 16, 2022
@DenverCoder1
Copy link
Owner

Everything looks good 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate linting with prettier workflow
2 participants
@Vyvy-vi @DenverCoder1