Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapbox-gl customAttribution options #28338

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

mklopets
Copy link
Contributor

@mklopets mklopets commented Aug 23, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@mklopets mklopets changed the title Mapbox gl 0.48 mapbox-gl customAttribution Aug 23, 2018
@mklopets mklopets changed the title mapbox-gl customAttribution Add mapbox-gl customAttribution options Aug 23, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 23, 2018

@mklopets Thank you for submitting this PR!

🔔 @dobrud @PatrickR - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Aug 28, 2018
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants