-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(silo-finance): exclude deprecated silos #822
feat(silo-finance): exclude deprecated silos #822
Conversation
ty for updating. tests are failing though |
@slasher125 the tests run successfully locally, I think the issue is that the multicall requests are failing on the test server on GitHub for some reason, from test log:
Since the on-chain calls aren't working, there are no values, which results in the test failing. If I run the tests locally the calls don't fail and all the tests pass. |
Here is the log I get when I run the test locally:
|
The silo-finance adapter exports pools: Test Suites: 1 passed, 1 total
|
Related to: DefiLlama/DefiLlama-Adapters#6575
This adds basic fallback functionality to exclude deprecated silos whilst the functionality is being worked on to include such data in the subgraph responses.
We also bump up the subgraph version to latest stable.
The diff looks like a lot changed but all that was actually changed was bumping up subgraph version, adding
fallbackBlacklist
array, filtering deprecated markets out of thesiloAddresses
and wrapping anif(fallbackBlacklist.indexOf(id.toLowerCase()) === -1) {...}
around the logic that runs for each market.