Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Markdown files to doc directory #305

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Moved Markdown files to doc directory #305

merged 7 commits into from
Oct 12, 2023

Conversation

shaswat-satyam
Copy link
Contributor

@shaswat-satyam shaswat-satyam commented Oct 9, 2023 •
edited by PSNAppz
Loading

Issue #304

Changes Proposed

  • Moved Markdown Files to a separate doc Directory

PSNAppz
PSNAppz requested changes Oct 9, 2023
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
KingAkeem
KingAkeem requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the pull request template? It's being moved in another PR, #306.

@shaswat-satyam
Copy link
Contributor Author

Done

PSNAppz
PSNAppz previously requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@PSNAppz PSNAppz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. We are referencing the Licensing url in Readme. Can you fix that also?

@shaswat-satyam
Copy link
Contributor Author

There you go!

KingAkeem
KingAkeem requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@KingAkeem KingAkeem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the LICENSE.md back to the root directory so that it can be detected by GitHub?

@KingAkeem KingAkeem self-requested a review October 12, 2023 17:16
@KingAkeem KingAkeem dismissed PSNAppz’s stale review October 12, 2023 17:17

Request completed

@KingAkeem KingAkeem merged commit 7df1e9e into DedSecInside:dev Oct 12, 2023
1 check passed
@PSNAppz PSNAppz mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingAkeem KingAkeem KingAkeem approved these changes

@PSNAppz PSNAppz Awaiting requested review from PSNAppz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaswat-satyam @PSNAppz @KingAkeem