Do not call method that was removed in Python 3.9 in six #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to help google#12027
You linked to a log with a failure for six - https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4180e85e-4b31-4442-849a-2188343052bc.txt
The failure makes sense as a result of the Python version upgrade, since in Python 3.9, 'unescape' was removed from HTMLParser - https://docs.python.org/3/whatsnew/3.9.html#porting-to-python-3-9
However, if you look at the six source code,
unescapeisn't even used. HTMLParser is sure, but that's it. So I think the problematic code can be removed from fuzz_six.py - the method is gone in Python >= 3.9, and Python 3.8 is EOL, so there's no need to continue testing it.