Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary public #176

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Remove unnecessary public #176

merged 1 commit into from
Dec 23, 2021

Conversation

vickenty
Copy link
Contributor

@vickenty vickenty commented Dec 23, 2021

Client channel is an implementation detail of the client, and the method where
the channel classes are used is private. There is no need for these classes to
be public.

Modified files were added in #169 and were never released yet.

Client channel is an implementation detail of the client, and the method where
the channel classes are used is private. There is no need for these classes to
be public.
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks!

@vickenty vickenty merged commit 0328873 into master Dec 23, 2021
@vickenty vickenty deleted the vickenty/priv branch January 6, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants