Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: workaround for centos 7 eol #9698

Closed
wants to merge 5 commits into from
Closed

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jul 2, 2024

Read more: pypa/cibuildwheel#1915

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jul 2, 2024
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: gnufede/cibuildwheel-workaround
Commit report: bbcb312
Test service: dd-trace-py

❌ 305 Failed (0 Known Flaky), 118790 Passed, 38583 Skipped, 2h 37m 41.17s Total duration (59m 33.51s time saved)
❄️ 217 New Flaky

❌ Failed Tests (305)

This report shows up to 5 failed tests.

  • test_200_request - test_aiohttp_client.py - Details

    Expand for error
     Could not connect to test agent: [Errno 111] Connection refused
    
  • test_200_request_distributed_tracing - test_aiohttp_client.py - Details

    Expand for error
     Cannot connect to host localhost:8001 ssl:default [Connect call failed ('127.0.0.1', 8001)]
    
  • test_200_request_post - test_aiohttp_client.py - Details

    Expand for error
     Could not connect to test agent: [Errno 111] Connection refused
    
  • test_500_request - test_aiohttp_client.py - Details

    Expand for error
     Could not connect to test agent: [Errno 111] Connection refused
    
  • test_auth_200_request - test_aiohttp_client.py - Details

    Expand for error
     Could not connect to test agent: [Errno 111] Connection refused
    

New Flaky Tests (217)

  • test_unspecified_service_v1 - test_aiomysql.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_unspecified_service_v1" Failed (exit code 1):
     /root/project/tests/contrib/asyncio/utils.py:46: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
       coro = asyncio.coroutine(f)
     /root/.pyenv/versions/3.9.16/lib/python3.9/unittest/case.py:553: RuntimeWarning: coroutine 'AioMySQLTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     E
     ======================================================================
     ERROR: test_unspecified_service_v1 (tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase)
     ----------------------------------------------------------------------
     ...
    
  • test_user_specified_service_v0 - test_aiomysql.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_user_specified_service_v0" Failed (exit code 1):
     /root/project/tests/contrib/asyncio/utils.py:46: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
       coro = asyncio.coroutine(f)
     /root/.pyenv/versions/3.9.16/lib/python3.9/unittest/case.py:553: RuntimeWarning: coroutine 'AioMySQLTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     E
     ======================================================================
     ERROR: test_user_specified_service_v0 (tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase)
     ----------------------------------------------------------------------
     ...
    
  • test_asyncpg_dbm_propagation_comment_integration_service_name_override - test_asyncpg.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.asyncpg.test_asyncpg.AsyncPgTestCase.test_asyncpg_dbm_propagation_comment_integration_service_name_override" Failed (exit code 1):
     /root/project/tests/contrib/asyncio/utils.py:46: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
       coro = asyncio.coroutine(f)
     /root/.pyenv/versions/3.9.16/lib/python3.9/unittest/case.py:553: RuntimeWarning: coroutine 'AsyncPgTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     E
     ======================================================================
     ERROR: test_asyncpg_dbm_propagation_comment_integration_service_name_override (tests.contrib.asyncpg.test_asyncpg.AsyncPgTestCase)
     tests if dbm comment is set in postgres
     ...
    
  • test_asyncpg_dbm_propagation_comment_peer_service_enabled - test_asyncpg.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.asyncpg.test_asyncpg.AsyncPgTestCase.test_asyncpg_dbm_propagation_comment_peer_service_enabled" Failed (exit code 1):
     /root/project/tests/contrib/asyncio/utils.py:46: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
       coro = asyncio.coroutine(f)
     /root/.pyenv/versions/3.9.16/lib/python3.9/unittest/case.py:553: RuntimeWarning: coroutine 'AsyncPgTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     E
     ======================================================================
     ERROR: test_asyncpg_dbm_propagation_comment_peer_service_enabled (tests.contrib.asyncpg.test_asyncpg.AsyncPgTestCase)
     tests if dbm comment is set in postgres
     ...
    
  • test_asyncpg_dbm_propagation_comment_pin_service_name_override - test_asyncpg.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.asyncpg.test_asyncpg.AsyncPgTestCase.test_asyncpg_dbm_propagation_comment_pin_service_name_override" Failed (exit code 1):
     /root/project/tests/contrib/asyncio/utils.py:46: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
       coro = asyncio.coroutine(f)
     /root/.pyenv/versions/3.9.16/lib/python3.9/unittest/case.py:553: RuntimeWarning: coroutine 'AsyncPgTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     E
     ======================================================================
     ERROR: test_asyncpg_dbm_propagation_comment_pin_service_name_override (tests.contrib.asyncpg.test_asyncpg.AsyncPgTestCase)
     tests if dbm comment is set in postgres
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented Jul 2, 2024

Benchmarks

Benchmark execution time: 2024-07-02 13:34:05

Comparing candidate commit 1039e51 in PR branch gnufede/cibuildwheel-workaround with baseline commit 9c9b5a7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@gnufede
Copy link
Member Author

gnufede commented Jul 2, 2024

Closing in favor of #9700

@gnufede gnufede closed this Jul 2, 2024
@gnufede gnufede deleted the gnufede/cibuildwheel-workaround branch July 2, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant