Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): code provenance using libdatadog exporter [backport 2.14] #10856

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 27, 2024

Backport 4363516 from #10796 to 2.14.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 4363516)
@github-actions github-actions bot requested a review from a team as a code owner September 27, 2024 20:51
@github-actions github-actions bot added the Profiling Continous Profling label Sep 27, 2024
@github-actions github-actions bot requested a review from a team as a code owner September 27, 2024 20:51
@taegyunkim taegyunkim closed this Sep 27, 2024
@taegyunkim taegyunkim reopened this Sep 27, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/dd_wrapper/include/code_provenance.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/code_provenance_interface.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/code_provenance.cpp   @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/code_provenance_interface.cpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/code_provenance.cpp  @DataDog/profiling-python
releasenotes/notes/profiling-libdd-code-provenance-37f9e3451b0c532c.yaml  @DataDog/apm-python
ddtrace/internal/datadog/profiling/dd_wrapper/CMakeLists.txt            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/libdatadog_helpers.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/ddup_interface.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/sample.cpp            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader.cpp          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/CMakeLists.txt       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/test_utils.hpp       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyi                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyx                       @DataDog/profiling-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024

Benchmarks

Benchmark execution time: 2024-10-02 00:24:11

Comparing candidate commit 540694a in PR branch backport-10796-to-2.14 with baseline commit a213e8d in branch 2.14.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 344 metrics, 48 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) October 2, 2024 00:25
@taegyunkim taegyunkim merged commit 73d3d41 into 2.14 Oct 2, 2024
619 checks passed
@taegyunkim taegyunkim deleted the backport-10796-to-2.14 branch October 2, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant