Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtracer/tracer: marshalled span values in encode span #832

Merged
merged 7 commits into from
Feb 25, 2021
Merged

ddtracer/tracer: marshalled span values in encode span #832

merged 7 commits into from
Feb 25, 2021

Commits on Feb 3, 2021

  1. ddtracer/tracer: marshalled span values in encode span 

    Illegal characters, such as newlines, were not escaped in encodeSpan function, which ruined json structure. Closes #791
    @dianashevchenko
    dianashevchenko committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    ed89fab View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. ddtrace/tracer: added marshalling keys to metrics encoding 

    Added same marshalling to encoding metrics keys. Also, added error logging to both metrics and meta marshalling
    @dianashevchenko
    dianashevchenko committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    e27da29 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. ddtrace/tracer: refactored test and error message format

    @dianashevchenko
    dianashevchenko committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    1e47f02 View commit details
    Browse the repository at this point in the history

  2. ddtrace/tracer: sanitized other string variables that could break JSON 

    Service, resource, and operation names were too marshalled to make sure they don't break JSON with invalid characters such as newlines
    @dianashevchenko
    dianashevchenko committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e8a1af0 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. ddtrace/tracer: refactored duplicate code to use marshalString instead

    @dianashevchenko
    dianashevchenko committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    bd499a7 View commit details
    Browse the repository at this point in the history

  2. ddtrace/tracer: expanded a test case to cover other fields sanitized … 

    …by marshalString
    @dianashevchenko
    dianashevchenko committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    68759ee View commit details
    Browse the repository at this point in the history

  3. ddtrace/tracer: refactored test case

    @dianashevchenko
    dianashevchenko committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    35468de View commit details
    Browse the repository at this point in the history