contrib/gorilla/mux: option for skipping tracing #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
previously requested changes
Dec 16, 2020
There was a problem hiding this comment.
Hey! Thanks for contributing to dd-trace-go! Please take a moment to read our short contribution guidelines: https://github.com/DataDog/dd-trace-go/blob/v1/CONTRIBUTING.md
Wow, you were fast. I was about too 👍 |
stroem
changed the title
stroem
changed the title
stroem
changed the title
|
@gbbr what about now? :) |
|
Better! Thanks a lot! Usually it's done the other way around and the PR would come last, so I jumped in to look :) Will review soon... |
gbbr
reviewed
Dec 17, 2020
|
I want to run unit tests on this before merging. |
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds an option called WithSkippingFunc, which can be used for skipping tracing based on request path.
Issue #790