-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/go-redis/redis.v8: support go-redis.v8 #727
Conversation
758084e
to
cb69061
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I only have a few comments.
Sorry for the delay updated the PR, do not hesitate if there is anything else that need to me done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @sfroment
4ba99db
to
19b11d1
Compare
3bfa039
to
7371572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks.
@sfroment Since v1.27.0
was released, the PR needs to be rebased on v1
in order to get the tests to pass.
I am happy to rebase this for you if you don't have time.
Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
* add interface validation at compile time * remove useless helper func Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
7371572
to
fc00f08
Compare
This is simply a port of contrib/go-redis/redis, but for go-redis.v8 with the new Hook mechanism.