ddtrace/tracer: updated DD_TAGS parsing to support space separation #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DD_TAGS were split by commas only. Unless there is a comma in a string, tag list will be split by spaces. In either case, commas/spaces will be trimmed.
gbbr
changed the title
gbbr
reviewed
Feb 9, 2021
gbbr
reviewed
Feb 9, 2021
ddtrace/tracer/option_test.go
Outdated
| in: "a,1", | ||
| expected: map[string]string{ | ||
| "a": "", | ||
| "1": ""}, |
There was a problem hiding this comment.
This curly brace should also go on the next line everywhere. Sorry if my initial message was unclear.
ddtrace/tracer/option_test.go
Outdated
| os.Setenv("DD_TAGS", tag.in) | ||
| c := newConfig() | ||
| for key, expected := range tag.expected { | ||
| actual, ok := c.globalTags[key] |
There was a problem hiding this comment.
Suggested change
| actual, ok := c.globalTags[key] | |
| v, ok := c.globalTags[key] |
Can we please use v or got?
There was a problem hiding this comment.
v is used everywhere above, so I did not change that
Refactored parsing tests, removed comma trimming in the profiler/options.go.
gbbr
approved these changes
Feb 10, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DD_TAGS were split by commas only. Unless there is a comma in a string, tag list will be split by spaces. In either case, commas/spaces will be trimmed.