Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: make DD_TAGS space separated #783

Closed
alainstoffels opened this issue Dec 9, 2020 · 3 comments
Closed

proposal: make DD_TAGS space separated #783

alainstoffels opened this issue Dec 9, 2020 · 3 comments
Labels
ack proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@alainstoffels
Copy link

We have a AWS ECS cluster which runs the Datadog agent and our services which are monitored with Datadog. We're using the DD_TAGS environment variable to set a couple of tags. We want these tags on the infrastructure hosts (which are set by the agent) and on all of our traces (which are set by this dd-trace-go package).

The agent requires these tags to be space separated but dd-trace-go requires them to be comma separated. I suggest making this consistent and thus making DD_TAGS space separated.

In our case it's quite cumbersome to pass a different DD_TAGS value to different containers within ECS so we would just like to use the same DD_TAGS variable across all our containers.

Removing comma separation would be a breaking change so it would probably be wise to keep supporting that and split both on commas and spaces

@knusbaum
Copy link
Contributor

We have this in our work queue.

@knusbaum knusbaum added the ack label Dec 22, 2020
@knusbaum knusbaum added proposal more in depth change that requires full team approval proposal/accepted Accepted proposals labels May 26, 2021
@katiehockman
Copy link
Contributor

@knusbaum the PR for this was closed, so should we mark this proposal as rejected, or do you still feel it's worth doing?

@knusbaum
Copy link
Contributor

Completed in #837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants