Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade datadog-cloudformation-common-python version #138

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Upgrade datadog-cloudformation-common-python version #138

merged 1 commit into from
Jun 28, 2021

Conversation

iwt-dennyschaefer
Copy link
Contributor

@iwt-dennyschaefer iwt-dennyschaefer commented Jun 21, 2021 •
edited
Loading

Requirements for Contributing to this repository

What does this PR do?

This pull request bumps common-python to version 0.0.6 in all resources.

When this code has been released, #127 should finally be fixed.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@iwt-dennyschaefer iwt-dennyschaefer requested a review from a team as a code owner June 21, 2021 13:56
@tuxinaut
Copy link

The title is a bit misleading now because I can not edit the issue title nor the content anymore.

@zippolyte please have a look, this pull request should be good to go after #146. If you have other plans please let me know and simply close the pull request!

@zippolyte zippolyte changed the title bump common python version to 0.0.5 in all resources Upgrade datadog-cloudformation-common-python version Jun 28, 2021
@zippolyte zippolyte added changelog/Added Added features results into a minor version bump resource/aws Impacts the datadog-aws-integration-handler package resource/dashboard resource/downtime Impacts the datadog-monitors-downtime-handler package resource/monitor Impacts the datadog-monitors-monitor-handler package resource/user Impacts the datadog-iam-user-handler package labels Jun 28, 2021
@zippolyte zippolyte merged commit 17281c5 into DataDog:master Jun 28, 2021
@iwt-dennyschaefer
Copy link
Contributor Author

Sorry forgot what I wrote (LAYER 8 problem 🤦 ) above regarding I'm not able to edit the ticket. I had opened the tab in my private Firefox container instead of the work one .....

@zippolyte
Copy link
Contributor

Thanks, I'll release the resources next now that this is merged

@iwt-dennyschaefer
Copy link
Contributor Author

Thanks, I'll release the resources next now that this is merged

Awesome thx 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zippolyte zippolyte zippolyte approved these changes

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump resource/aws Impacts the datadog-aws-integration-handler package resource/dashboard resource/downtime Impacts the datadog-monitors-downtime-handler package resource/monitor Impacts the datadog-monitors-monitor-handler package resource/user Impacts the datadog-iam-user-handler package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwt-dennyschaefer @tuxinaut @zippolyte