Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding user and cleaning up caches for Dockerfile #366

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Adding user and cleaning up caches for Dockerfile #366

merged 1 commit into from
Sep 7, 2023

Conversation

lhr-git
Copy link
Contributor

@lhr-git lhr-git commented Sep 6, 2023 •
edited
Loading

ADO-139302

Fixed AB#139302

Changelog

  • fix: Dockerfile running as root user
  • fix: missing port environment variables
  • fix: added cache purging to npm install commands to clean up room in the same step
  • fix: updated alpine container version

Description of proposed changes:

With this the dockerfile no longer runs as root, and the size of the image shrinks a bit

What to test for/How to test

Everything should work exactly the same as it did before. This only changes what our application runs as.

Additional Notes

@lhr-git lhr-git requested a review from a team as a code owner September 6, 2023 14:36
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Integration Deployment 🚀 - Build Status
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

krischarbonneau
krischarbonneau approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhr-git lhr-git merged commit 00ab6c5 into dev Sep 7, 2023
8 checks passed
@lhr-git lhr-git deleted the lharrison-dockerfile-user-fix branch September 7, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krischarbonneau krischarbonneau krischarbonneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhr-git @krischarbonneau