Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not specific to Win 10 #302

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Not specific to Win 10 #302

merged 1 commit into from
Mar 9, 2023

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Mar 9, 2023

These instructions should equally good or bad on Windows 10 or 11 (maybe even Windows 7🤔)

No need to pinpoint Windows 10.

Closes #301

@ecomodeller ecomodeller linked an issue Mar 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #302 (409b970) into main (03344ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          49       49           
  Lines        2207     2207           
  Branches      304      304           
=======================================
  Hits         2178     2178           
  Misses         19       19           
  Partials       10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ecomodeller!

@j08lue j08lue merged commit 6e12098 into main Mar 9, 2023
@j08lue j08lue deleted the windows_version branch March 9, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 10?
2 participants