Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/scenarios old fetch scenarios by query with filter #370

Merged

Conversation

JacobJsuh
Copy link
Contributor

This PR

Adds a prop to scenarios old allowing to add a custom filter to fetch scenarios by.

Adds the scenarios post method for fetching scenarios, this allows finer filtering as the filter is part of the post and not just limited to dateTime.

Closes #xxx

Notes

  • No notes to add

Fulfilled the scope of this repo?

  • [x ] The same functionality of the component can not be achieved with theming, basic styling or composition of existing components
  • [x ] The component implements an element of the DHI Design Guidelines or is otherwise generic enough in functionality and close enough to the DHI CVI that it is likely to find reuse in other projects

Completness

  • Story included

…llows filtering by any item on the scenario during the Post.

Add this methodology into the ScenariosOld component allowing users to input the QueryFilter as a prop which scenarios will then be fetched using.

This allows for more efficient fetching of data as only the scenarios matching the required filters are pulled across, reducing required filtering on the frontend and load on the api.
Copy link
Collaborator

@FranzThomsen1089 FranzThomsen1089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic

@JacobJsuh JacobJsuh marked this pull request as ready for review June 12, 2024 04:59
@JacobJsuh JacobJsuh merged commit 7be0206 into master Jun 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants