Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pfs quotes #448

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Pfs quotes #448

merged 6 commits into from
Oct 18, 2022

Conversation

ecomodeller
Copy link
Member

Closing #446

@ecomodeller ecomodeller marked this pull request as ready for review October 13, 2022 14:51
clemenscremer
clemenscremer approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@clemenscremer clemenscremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Could we - in theory also experience double doublequotes (""value"") and should we adress it as well?

@ecomodeller
Copy link
Member Author

ecomodeller commented Oct 17, 2022 •
edited
Loading

Works like a charm. Could we - in theory also experience double doublequotes (""value"") and should we adress it as well?

Let's deal with it when theory becomes practice.

@ecomodeller ecomodeller merged commit 990aa50 into main Oct 18, 2022
@ecomodeller ecomodeller mentioned this pull request Oct 18, 2022
Closed
@ecomodeller ecomodeller deleted the pfs_quotes branch October 25, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemenscremer clemenscremer clemenscremer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @clemenscremer