Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for BlockUniTensor and Bond #347

Open
wants to merge 2 commits into
base: dev-master
Choose a base branch
from
Open

Conversation

yingjerkao
Copy link
Collaborator

Bump up test coverage

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #347 (46c6d09) into dev-master (d7561ce) will increase coverage by 0.01%.
Report is 1 commits behind head on dev-master.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           dev-master     #347      +/-   ##
==============================================
+ Coverage       17.79%   17.81%   +0.01%     
==============================================
  Files             220      220              
  Lines           48736    48736              
  Branches        19932    19934       +2     
==============================================
+ Hits             8672     8681       +9     
+ Misses          35868    35852      -16     
- Partials         4196     4203       +7     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CMakeLists.txt Outdated
@@ -417,3 +417,8 @@ if(BUILD_PACKAGES)
include("Package.cmake")
include(CPack)
endif()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be neccessary?

Copy link
Collaborator

@IvanaGyro IvanaGyro Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean include(CTest) is not necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a commit explicitly including CTest to suppress the warning. a66fbaa

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Thanks for the clarification!
Should we remove this block from this commit?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it will not break the cmake script.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But current cmakelist already contains include(CTest)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be there:

include(CTest)

I don't know why it doesn't show in the comparison tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants