-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: adjust python VCS related CycloneDX Properties Taxonomy names #782
Conversation
in accoedance with CycloneDX/cyclonedx-property-taxonomy#96 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
this might be considered a breaking-change, in case any of the changed enum values is used/applied when rendering CycloneDX. |
I see the quandry here - fix or breaking change - I'd err towards fix in this case (just). |
I'd consider it a breaking change, since the result/output changes in a way that ingesting pipelines and tools might break. |
That is a fair point @jkowalleck alas we might end up with almost all changes becoming breaking changes... |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
i might prepare a non-breaking patch, that introduces the fixed names in addition to the deprecated ones. |
this PR needs to be reworked after #789 got merged |
superseded by #791 |
in accordance with CycloneDX/cyclonedx-property-taxonomy#96