Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escalate various log messages #1138

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Dec 11, 2023

If result validation was explicitly requested but skipped, then show a warning
fixes #1137

some log messages were raised to be warnings, in case they lead to an error.

some wordings were changed

…a warning instead of an info message

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner December 11, 2023 14:00
@jkowalleck jkowalleck added the enhancement New feature or request label Dec 11, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title Explicite validate warn on skip Explicite validation warns when skipped Dec 11, 2023
@jkowalleck jkowalleck changed the title Explicite validation warns when skipped Explicit validation warns when skipped Dec 11, 2023
@jkowalleck jkowalleck changed the title Explicit validation warns when skipped escalate valrious log messages Dec 11, 2023
Copy link

codacy-production bot commented Dec 11, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.40% 72.22% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cd1d3c6) 1155 987 85.45%
Head commit (a9e27c1) 1164 (+9) 990 (+3) 85.05% (-0.40%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1138) 18 13 72.22%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title escalate valrious log messages Escalate various log messages Dec 11, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit 1256457 into main Dec 11, 2023
31 of 33 checks passed
@jkowalleck jkowalleck deleted the explicite-validate-warn-on-skip branch December 11, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more logs: skipped validation if requested
1 participant