Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure it works with Fastboot #60

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Ensure it works with Fastboot #60

merged 3 commits into from
Feb 3, 2020

Commits on Feb 3, 2020

  1. Use computed property for get-text component 

    The `didReceiveAttrs` was sometimes run multiple times, e.g. in Fastboot, leading to issues there. A CP will automatically use caching and not re-run if the message doesn't change.
    Francesco Novy committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    0b760bf View commit details
    Browse the repository at this point in the history

  2. Ensure it works with FastBoot 

    Note: The availableLocales CP in the dummy app triggered an immediate re-render, which tripped up FastBoot.
    Francesco Novy committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    6a73fad View commit details
    Browse the repository at this point in the history

  3. Ensure fingerprinting configuration is auto-fixed to work 

    This will ensure that if fingerprinting is enabled:

* It will also fingerprint .json files
* It will NOT fingerprint package.json, if FastBoot is used (this is generated by FastBoot on the fly)

It also means that users will not need to adjust their config anymore.
For clarity, we log any changes to the configuration in the console.
    Francesco Novy committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    8037507 View commit details
    Browse the repository at this point in the history