Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version Bumps + IBC v7.1.0 upgrade handler #718

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Version Bumps + IBC v7.1.0 upgrade handler #718

merged 2 commits into from
Jun 17, 2023

Conversation

Reecepbcups
Copy link
Contributor

No description provided.

@Reecepbcups
Copy link
Contributor Author

Reecepbcups commented Jun 16, 2023 •
edited
Loading

hmm IBC breakage from the 7 -> 7.1 bump without upgrade

odd, will dive more into. Did not see any app.go required changes in the changelog, maybe I missed it to register the exports typeURL

@faddat
Copy link
Contributor

faddat commented Jun 17, 2023 •
edited
Loading

I suspect it is interchain test and/or pfm having issues with 7.1 but I'm not certain of this.

I'm at least certain when it comes to pfm:

https://github.com/cosmos/ibc-apps/blob/8252b32d8c1342145b559f7a7b654bb0a11c3a6f/modules/async-icq/go.mod#L21

It shouldn't under any circumstances import tendermint. Fixing and will post pr here.

cosmos/ibc-apps#27

@Reecepbcups
Copy link
Contributor Author

Reecepbcups commented Jun 17, 2023 •
edited
Loading

I suspect it is interchain test and/or pfm having issues with 7.1 but I'm not certain of this.

I'm at least certain when it comes to pfm:

https://github.com/cosmos/ibc-apps/blob/8252b32d8c1342145b559f7a7b654bb0a11c3a6f/modules/async-icq/go.mod#L21

It shouldn't under any circumstances import tendermint. Fixing and will post pr here.

cosmos/ibc-apps#27

Having tendermint as an import is nothing even related to the issue / logs provided.

Issue with with rly, Justin has a fix here: cosmos/relayer#1191

@Reecepbcups Reecepbcups marked this pull request as ready for review June 17, 2023 06:43
@Reecepbcups Reecepbcups enabled auto-merge (squash) June 17, 2023 07:00
dimiandre
dimiandre approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@dimiandre dimiandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faddat
Copy link
Contributor

faddat commented Jun 17, 2023

@Reecepbcups ok, I will still assert that it's something that should never happen on 47....

@Reecepbcups Reecepbcups merged commit aa381a8 into main Jun 17, 2023
17 checks passed
@Reecepbcups Reecepbcups deleted the sdk47-version-bumps branch June 18, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimiandre dimiandre dimiandre approved these changes

@faddat faddat faddat approved these changes

@the-frey the-frey Awaiting requested review from the-frey

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell is a code owner

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Reecepbcups @faddat @dimiandre