New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Weighted Operations to simulation #825

Closed

pinosu wants to merge 7 commits into main from 797-add_ops_simulation

Contributor

pinosu commented Apr 28, 2022 •

edited

Loading

See #797

Add support for:

MsgStoreCode
MsgInstantiateContract

Simulations can be run with test-sim-multi-seed-short and make test-sim-import-export

pinosu force-pushed the 797-add_ops_simulation branch from 3d7b798 to f23006f Compare

April 28, 2022 21:47


          Add Weighted Operations to simulation

e11bfe7

pinosu force-pushed the 797-add_ops_simulation branch from f23006f to e11bfe7 Compare

April 28, 2022 22:01

codecov bot commented Apr 28, 2022 •

edited

Loading

Codecov Report

Merging #825 (283bde0) into main (8ca55b7) will decrease coverage by 0.07%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   59.37%   59.30%   -0.08%     
==========================================
  Files          51       51              
  Lines        5898     5885      -13     
==========================================
- Hits         3502     3490      -12     
+ Misses       2144     2143       -1     
  Partials      252      252

Impacted Files	Coverage Δ
x/wasm/types/params.go	`60.21% <ø> (-1.33%)`	⬇️
x/wasm/types/validation.go	`100.00% <ø> (ø)`
x/wasm/module.go	`49.45% <75.00%> (+1.13%)`	⬆️
app/app.go	`88.94% <100.00%> (ø)`
x/wasm/keeper/keeper.go	`87.39% <100.00%> (-0.44%)`	⬇️

alpe and others added 5 commits

April 29, 2022 10:47


          Make simulations pass

2a4ea51


          Consolidate MaxWasmSize constraints into a single var (#826)

bfb4d31

* Convert MaxWasmSize to var

Also removes redundant maxWasmSize param

* Convert MaxWasmSize to int

* Update CHANGELOG

* Complete max wasm size changes

* Update compile flags

Co-authored-by: Cole Brown <bigswim@gmail.com>


          Add Weighted Operations to simulation

a872930


          Make simulations pass

dd567ae


          Rebase to master branch

fd88b6a

pinosu marked this pull request as ready for review

May 2, 2022 10:05

pinosu requested a review from alpe as a code owner

May 2, 2022 10:05


          Add InstantiateContract msg simulation

283bde0

alpe reviewed

View reviewed changes

Member

alpe left a comment

Very nice start!
Please rebase and use CodeInfos to find a code id

CHANGELOG.md

@@ @@ -2,6 +2,10 @@ @@
               ## [Unreleased](https://github.com/CosmWasm/wasmd/tree/HEAD)
+              **Merged pull requests:**
+              - Consolidate MaxWasmSize constraints into a single var [\#826](https://github.com/CosmWasm/wasmd/pull/826)

Member

alpe May 2, 2022

🤔 this is in main already. I think you PR was not rebased proper

app/params/weights.go

@@ @@ -20,4 +20,6 @@ const ( @@
               	DefaultWeightCommunitySpendProposal int = 5
               	DefaultWeightTextProposal           int = 5
               	DefaultWeightParamChangeProposal    int = 5
+              	DefaultWeightMsgStoreCode           int = 100
+              	DefaultWeightMsgInstantiateContract int = 5

Member

alpe May 2, 2022

Let's make this high as well to get some load on our module

x/wasm/simulation/operations.go

+              			return true
+              		})
+              		if contractInfo.Equal(types.ContractInfo{}) {

Member

alpe May 2, 2022

You need to look for a CodeInfo here. The system won't have contract instances in the beginning and you abort here so that none will be created

x/wasm/simulation/operations.go

+              			return simtypes.NoOpMsg(types.ModuleName, types.MsgInstantiateContract{}.Type(), "no contracts available"), nil, nil
+              		}
+              		spendable := bk.SpendableCoins(ctx, simAccount.Address)

Member

alpe May 2, 2022

Very nice to send some tokens. 💸
Test accounts will get broke fast though. How about sending a random amount with simtypes.RandSubset as the sdk does?

x/wasm/simulation/operations.go

+              		msg := types.MsgInstantiateContract{
+              			Sender: simAccount.Address.String(),
+              			Admin:  contractInfo.Admin,

Member

alpe May 2, 2022

Please use a random account address here. Empty string is valid too.

x/wasm/simulation/operations.go

+              			Sender: simAccount.Address.String(),
+              			Admin:  contractInfo.Admin,
+              			CodeID: contractInfo.CodeID,
+              			Label:  simtypes.RandStringOfLength(r, 10),

Member

alpe May 2, 2022

👍

x/wasm/simulation/operations.go

+              			Admin:  contractInfo.Admin,
+              			CodeID: contractInfo.CodeID,
+              			Label:  simtypes.RandStringOfLength(r, 10),
+              			Msg:    []byte(fmt.Sprintf(`{"%s": "%s"}`, simtypes.RandStringOfLength(r, 10), simtypes.RandStringOfLength(r, 10))),

Member

alpe May 2, 2022

The reflect contract expects an empty object on instantiation

pinosu mentioned this pull request

Add MsgStoreCode and MsgInstantiateContract support to simulations #831

Merged

Contributor Author

pinosu commented May 2, 2022

Closing in favour of #831

pinosu closed this

alpe deleted the 797-add_ops_simulation branch

May 10, 2023 08:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet