Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newly added panicking_add/panicking_sub for Timestamp math #2098

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Use newly added panicking_add/panicking_sub for Timestamp math #2098

merged 6 commits into from
Apr 10, 2024

Conversation

webmaster128
Copy link
Member

No description provided.

@webmaster128 webmaster128 mentioned this pull request Apr 10, 2024
Closed
chipshort
chipshort reviewed Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just typos

packages/std/src/timestamp.rs Outdated Show resolved Hide resolved
chipshort
chipshort approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmaster128 webmaster128 merged commit c7da5e3 into main Apr 10, 2024
30 checks passed
@webmaster128 webmaster128 deleted the panicking_sub branch April 10, 2024 10:16
@webmaster128
Copy link
Member Author

@mergify backport release/2.0 release/1.5 release /1.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024

backport release/2.0 release/1.5 release /1.4

❌ Sorry but I didn't understand the arguments of the command backport. Please consult the commands documentation 📚.

@webmaster128
Copy link
Member Author

@mergify backport release/2.0 release/1.5 release/1.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024 •
edited
Loading

backport release/2.0 release/1.5 release/1.4

✅ Backports have been created

This was referenced Apr 10, 2024
Merged
Merged
Merged
webmaster128 added a commit that referenced this pull request Apr 10, 2024
@mergify @webmaster128
Use newly added panicking_add/panicking_sub for Timestamp math (backp…
56edb12 
…ort #2098) (#2103)

* Add panicking_sub to Uint64/Uint128/Uint256/Uint512

(cherry picked from commit 547efed)

# Conflicts:
#	CHANGELOG.md

* Improve docs of Timestamp::minus_* and use panicking_sub

(cherry picked from commit 242cc1f)

# Conflicts:
#	CHANGELOG.md

* Add Uint{64,128,256,512}::panicking_add

(cherry picked from commit a74aba0)

# Conflicts:
#	CHANGELOG.md

* Add #[inline] annotations to plus_seconds/minus_seconds

(cherry picked from commit bbb788d)

* Make overflow behaviour explicit for Timestamp

(cherry picked from commit b265b33)

# Conflicts:
#	CHANGELOG.md

* Add PR link to new CHANGELOG entries

(cherry picked from commit 198001e)

# Conflicts:
#	CHANGELOG.md

* Fix CHANGELOG

---------

Co-authored-by: Simon Warta <simon@warta.it>
webmaster128 added a commit that referenced this pull request Apr 10, 2024
@mergify @webmaster128
Use newly added panicking_add/panicking_sub for Timestamp math (backp…
695970c 
…ort #2098) (#2104)

* Add panicking_sub to Uint64/Uint128/Uint256/Uint512

(cherry picked from commit 547efed)

# Conflicts:
#	CHANGELOG.md

* Improve docs of Timestamp::minus_* and use panicking_sub

(cherry picked from commit 242cc1f)

# Conflicts:
#	CHANGELOG.md

* Add Uint{64,128,256,512}::panicking_add

(cherry picked from commit a74aba0)

# Conflicts:
#	CHANGELOG.md

* Add #[inline] annotations to plus_seconds/minus_seconds

(cherry picked from commit bbb788d)

* Make overflow behaviour explicit for Timestamp

(cherry picked from commit b265b33)

# Conflicts:
#	CHANGELOG.md

* Add PR link to new CHANGELOG entries

(cherry picked from commit 198001e)

# Conflicts:
#	CHANGELOG.md

* Fix CHANGELOG

---------

Co-authored-by: Simon Warta <simon@warta.it>
webmaster128 added a commit that referenced this pull request Apr 10, 2024
@mergify @webmaster128
Use newly added panicking_add/panicking_sub for Timestamp math (backp…
e29dbf7 
…ort #2098) (#2105)

* Add panicking_sub to Uint64/Uint128/Uint256/Uint512

(cherry picked from commit 547efed)

# Conflicts:
#	CHANGELOG.md

* Improve docs of Timestamp::minus_* and use panicking_sub

(cherry picked from commit 242cc1f)

# Conflicts:
#	CHANGELOG.md

* Add Uint{64,128,256,512}::panicking_add

(cherry picked from commit a74aba0)

# Conflicts:
#	CHANGELOG.md

* Add #[inline] annotations to plus_seconds/minus_seconds

(cherry picked from commit bbb788d)

* Make overflow behaviour explicit for Timestamp

(cherry picked from commit b265b33)

# Conflicts:
#	CHANGELOG.md

* Add PR link to new CHANGELOG entries

(cherry picked from commit 198001e)

# Conflicts:
#	CHANGELOG.md

* Fix CHANGELOG

* Use zero() and one() from functions in tests

ZERO / ONE are not yet available in 1.4

---------

Co-authored-by: Simon Warta <simon@warta.it>
@webmaster128 webmaster128 mentioned this pull request Apr 11, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @chipshort