Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly construct
Region
to uphold deallocation safety invariant #2062Correctly construct
Region
to uphold deallocation safety invariant #2062Changes from 3 commits
f3ae0fd
df9683e
c688732
666e709
682c5af
e0f963d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which provenance rules are you referring to?
The whole
memory
module is wasm32 only, such that we knowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, makes sense, but it's just internally a bunch of hints for the compiler and miri.
It contains stuff like the address space, address, and some other metadata which a
usize
can technically not accurately represent since it's just a pointer somewhere in memory.It's technically just an experiment but they also wanna explore if it makes sense for the compiler to enforce provenance at some point AFAIK.
https://doc.rust-lang.org/nightly/std/ptr/index.html#strict-provenance
But as the docs say
Just something that was on my mind and I commented in ¯\_(ツ)_/¯
We can remove the comment, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all good, no worries. I was just not sure if there is anything practically relevant we need to be careful of.