Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Coins helper #1687

Merged
merged 19 commits into from
Jun 21, 2023
Merged

Implement Coins helper #1687

merged 19 commits into from
Jun 21, 2023

Commits on Jun 21, 2023

  1. add Coins struct

    @larry0x @chipshort
    larry0x authored and chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    edd06a3 View commit details
    Browse the repository at this point in the history

  2. Ignore zero amount when adding coin to coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    c5b82d3 View commit details
    Browse the repository at this point in the history

  3. Add extend method for Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2da8432 View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ea2aab1 View commit details
    Browse the repository at this point in the history

  5. Add more trait impls for Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b963508 View commit details
    Browse the repository at this point in the history

  6. Add helper to Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    15c60ac View commit details
    Browse the repository at this point in the history

  7. Use Coin's FromStr impl in FromStr impl of Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    dab3146 View commit details
    Browse the repository at this point in the history

  8. Remove IntoIterator impls for now

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    4e38bcf View commit details
    Browse the repository at this point in the history

  9. Fix test

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    324289f View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
    @chipshort @webmaster128
    chipshort and webmaster128 committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    24e4d7a View commit details
    Browse the repository at this point in the history

  11. Add custom error type for Coins conversion

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0e3bc7e View commit details
    Browse the repository at this point in the history

  12. Remove Coin to Coins conversion

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b202f79 View commit details
    Browse the repository at this point in the history

  13. Remove equality impl between Coin and Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    94f5748 View commit details
    Browse the repository at this point in the history

  14. Handle empty string when parsing Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    23d5a45 View commit details
    Browse the repository at this point in the history

  15. Ignore zero values when creating Coins

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e977229 View commit details
    Browse the repository at this point in the history

  16. Add Coin subtraction

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f4ead00 View commit details
    Browse the repository at this point in the history

  17. Fix Coin subtraction

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    c02a2f1 View commit details
    Browse the repository at this point in the history

  18. Add Coin to Coins conversion test

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3f5ea72 View commit details
    Browse the repository at this point in the history

  19. Add Coins to changelog

    @chipshort
    chipshort committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    df8ff96 View commit details
    Browse the repository at this point in the history