Construct Coin from String #1684
Conversation
packages/std/src/coin.rs
Outdated
| assert_eq!( | ||
| Coin::from_str("ucosm").unwrap_err().to_string(), | ||
| "Invalid amount: cannot parse integer from empty string" | ||
| ); | ||
| assert_eq!( | ||
| Coin::from_str("-123ucosm").unwrap_err().to_string(), | ||
| "Invalid amount: cannot parse integer from empty string" | ||
| ); |
There was a problem hiding this comment.
Interesting test cases here.
Can we have a dedicated check for cases where the number does not start with a digit? Otherwise the error message is more misleasing than helping. The basic idea would be
- Ensure we start reading digits (not yet implemented)
- Once we get a non-digit, mark as separation point to denom (already implemented)
This would better cover cases like those:
Coin::from_str("ucosm") // no amount
Coin::from_str("") // empty input
Coin::from_str("-1ucosm") // negative amount
Coin::from_str(" 1ucosm") // unsupported whitespace
Coin::from_str("�1ucosm") // other broken data
There was a problem hiding this comment.
So, basically, there would be another error variant, something like "MissingAmount" that would throw in all those cases?
There was a problem hiding this comment.
I was thinking about using InvalidAmount for the new check, but given the error payload type and the separate check time, it is probably better to have MissingAmount or AmountNotFound separately.
There was a problem hiding this comment.
I added a check for this now. Only the empty one still throws MissingDenom, because that way the check becomes much more elegant (and I think both errors make sense here)
closes #1575