Add Decimal{,256}::to_uint_floor and ::to_uint_ceil #1603
Conversation
| @@ -2002,6 +2050,42 @@ mod tests { | |||
| )); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn decimal_to_uint_floor_works() { | |||
There was a problem hiding this comment.
Are those tests even needed? You have them in examples which makes them automatically tests (unless we disabled this behaviour for some reason? I don't think so). To me it is just a duplicate.
There was a problem hiding this comment.
Yeah, some are duplicates because I wrote the examples first. But I think it's good to have both to be able to optimize examples for teaching and tests for coverage long term.
You have them in examples which makes them automatically tests (unless we disabled this behaviour for some reason? I don't think so).
Yeah, doc tests are running as usual here
packages/std/src/math/decimal.rs
Outdated
| if (self.0 % Self::DECIMAL_FRACTIONAL).is_zero() { | ||
| self.0 / Self::DECIMAL_FRACTIONAL | ||
| } else { | ||
| self.0 / Self::DECIMAL_FRACTIONAL + Uint128::one() | ||
| } |
There was a problem hiding this comment.
If we want to go for efficiency here, I think that this would go a bit better because of avoiding the fairly expensive modulo:
if self.0.is_zero() {
Self::zero()
} else {
(Self.0 - Uint128::one) / Self::DECIMAL_FRACTIONAL + Uint128::one()
}There was a problem hiding this comment.
Good point, refactored
Right now people do
Uint128::one() * my_decimalto perform the same operation, which is correct but hard to read and less efficient.