-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update to Angular v18 #252
Conversation
193b47d
to
9c828e1
Compare
@Cordobo for your review |
403ad3d
to
c76351d
Compare
Any progress on this? Will really appreciate it for my ng 18 project :) |
What's poppin', don't mind me just watchin' 👀 😆 |
Really looking forward to this upgrade |
@Cordobo this is pending your review |
Can we please check this @Cordobo ? This is the only dependency I have I cant upgrade to angular 18. |
Any progress on this? really appreciate it if can be fast track this. Thanks. |
Angular 18 is two months old now, rather not force a dependency override. Please merge this :) |
@Cordobo We'd really appreciate it if you could merge this sooner. This is a great library and it's the only one holding us back from updating to v18. |
@Cordobo Do you have an estimated timeline for when this will be merged? This is the only package we are waiting on to complete our migration to Angular 18. |
I think its time to decide:
|
Are there any other packages? |
@everyone I think this would be a good replacement for anyone who still waiting for this PR like me https://github.com/mnahkies/ng-qrcode#readme |
A merge would help us too! |
I'm going to look at switching to the other component tomorrow. I'll report back my findings. |
@caboodal why not just use the fix? The one with overriding angular core version? Works good for me. Tested today |
@maxmayr95 we are using the fix but I don't want a dependency in our apps that's not being maintained. Angular versions are coming thick and fast the next one we might not be so lucky. |
Upgrade the packages to the latest version of Angular. close #251