Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to Angular v18 #252

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat: Update to Angular v18 #252

merged 1 commit into from
Jul 25, 2024

Conversation

moh4sa
Copy link
Contributor

@moh4sa moh4sa commented May 30, 2024

Upgrade the packages to the latest version of Angular. close #251

@moh4sa moh4sa force-pushed the main branch 2 times, most recently from 193b47d to 9c828e1 Compare May 31, 2024 10:35
@moh4sa
Copy link
Contributor Author

moh4sa commented May 31, 2024

@Cordobo for your review

@moh4sa moh4sa force-pushed the main branch 2 times, most recently from 403ad3d to c76351d Compare June 2, 2024 14:53
@Arthi93
Copy link

Arthi93 commented Jun 4, 2024

Any progress on this? Will really appreciate it for my ng 18 project :)

@Cordobo Cordobo self-assigned this Jun 6, 2024
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@kyjus25
Copy link

kyjus25 commented Jun 10, 2024

What's poppin', don't mind me just watchin' 👀 😆

@lvetskov
Copy link

Really looking forward to this upgrade

@moh4sa
Copy link
Contributor Author

moh4sa commented Jun 15, 2024

@Cordobo this is pending your review

@alexookah
Copy link

Can we please check this @Cordobo ? This is the only dependency I have I cant upgrade to angular 18.

Sekators

This comment was marked as resolved.

@siddharthcn21
Copy link

Any progress on this? really appreciate it if can be fast track this. Thanks.

@JustroX
Copy link

JustroX commented Jun 19, 2024

Just in case you need to urgently update, you may want temporarily add this to package.json while waiting
image

@xanather
Copy link

xanather commented Jul 5, 2024

Angular 18 is two months old now, rather not force a dependency override. Please merge this :)

@behdi
Copy link

behdi commented Jul 12, 2024

@Cordobo We'd really appreciate it if you could merge this sooner. This is a great library and it's the only one holding us back from updating to v18.

@A-ahmadisalem
Copy link

@Cordobo Do you have an estimated timeline for when this will be merged? This is the only package we are waiting on to complete our migration to Angular 18.

@xanather
Copy link

I think its time to decide:

  1. Maintainer adds more other maintainers with write access
  2. Fork this
  3. Use a different package

@caboodal
Copy link

Are there any other packages?

@moh4sa
Copy link
Contributor Author

moh4sa commented Jul 22, 2024

@everyone I think this would be a good replacement for anyone who still waiting for this PR like me https://github.com/mnahkies/ng-qrcode#readme

@maxmayr95
Copy link

A merge would help us too!

@caboodal
Copy link

I'm going to look at switching to the other component tomorrow. I'll report back my findings.

@maxmayr95
Copy link

@caboodal why not just use the fix? The one with overriding angular core version? Works good for me. Tested today

@caboodal
Copy link

@maxmayr95 we are using the fix but I don't want a dependency in our apps that's not being maintained. Angular versions are coming thick and fast the next one we might not be so lucky.

@Cordobo Cordobo merged commit 24bae02 into Cordobo:main Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for Angular v18