Name to uid change #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2021 08:18
skolyszewski
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Hey @maciejmazur10c , thanks for contributing!
The code looks good, just a small note, for the future:
The change should be preceded by creating an issue, bug in this case. It would be ideal, if it had the failing scenario input and output, on top of the description. More about that can be found in our contributing guide (/CONTRIBUTING.md).
Since this change is really straightforward, we can make an exception here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool didn't work with Grafana v.8.1.6, because it is no longer possible to call /api/dashboards/{name} endpoint so it was returning "dashboard not found" error. I modified the code to verify dashboards over their UID.