[Upgrade] Go-Ethereum release v1.9.23 #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface (#21091) * accounts/abi: refactored abi.Unpack * accounts/abi/bind: fixed error * accounts/abi/bind: modified template * accounts/abi/bind: added ToStruct for conversion * accounts/abi: reenabled tests * accounts/abi: fixed tests * accounts/abi: fixed tests for packing/unpacking * accounts/abi: fixed tests * accounts/abi: added more logic to ToStruct * accounts/abi/bind: fixed template * accounts/abi/bind: fixed ToStruct conversion * accounts/abi/: removed unused code * accounts/abi: updated template * accounts/abi: refactored unused code * contracts/checkpointoracle: updated contracts to sol ^0.6.0 * accounts/abi: refactored reflection logic * accounts/abi: less code duplication in Unpack* * accounts/abi: fixed rebasing bug * fix a few typos in comments * rebase on master Co-authored-by: Guillaume Ballet <gballet@gmail.com>
* mobile: added constructor for big int * mobile: tiny nitpick
…#21572) * Fix potential memory leak in price heap * core: nil free pointer slice (alternative version) Co-authored-by: Martin Holst Swende <martin@swende.se>
… console api (#21608)
* ci: tooltips for javadoc for mobile app * f space
core/types: use stacktrie for derivesha trie: add stacktrie file trie: fix linter core/types: use stacktrie for derivesha rebased: adapt stacktrie to the newer version of DeriveSha Co-authored-by: Martin Holst Swende <martin@swende.se> More linter fixes review feedback: no key offset for nodes converted to hashes trie: use EncodeRLP for full nodes core/types: insert txs in order in derivesha trie: tests for derivesha with stacktrie trie: make stacktrie use pooled hashers trie: make stacktrie reuse tmp slice space trie: minor polishes on stacktrie trie/stacktrie: less rlp dancing core/types: explain the contorsions in DeriveSha ci: fix goimport errors trie: clear mem on subtrie hashing squashme: linter fix stracktrie: use pooling, less allocs (#3) trie: in-place hex prefix, reduce allocs and add rawNode.EncodeRLP Reintroduce the `[]node` method, add the missing `EncodeRLP` implementation for `rawNode` and calculate the hex prefix in place. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
* accounts, signer: implement gnosis safe support * common/math: add type for marshalling big to dec * accounts, signer: properly sign gnosis requests * signer, clef: implement account_signGnosisTx * signer: fix auditlog print, change rpc-name (signGnosisTx to signGnosisSafeTx) * signer: pass validation-messages/warnings to the UI for gnonsis-safe txs * signer/core: minor change to validationmessages of typed data
* trie: update tests to check commit integrity * trie: polish committer * trie: fix typo * trie: remove hasvalue notion According to the benchmarks, type assertion between the pointer and interface is extremely fast. BenchmarkIntmethod-12 1000000000 1.91 ns/op BenchmarkInterface-12 1000000000 2.13 ns/op BenchmarkTypeSwitch-12 1000000000 1.81 ns/op BenchmarkTypeAssertion-12 2000000000 1.78 ns/op So the overhead for asserting whether the shortnode has "valuenode" child is super tiny. No necessary to have another field. * trie: linter nitpicks Co-authored-by: Martin Holst Swende <martin@swende.se>
…1649) * core/state/snapshot: exit Geth if generator hits missing trie nodes * core/state/snapshot: error instead of hard die on generator fault * core/state/snapshot: don't enable logging on the tests
* params: update pegasys besu bootnode * params: update goerli initiative bootnodes
* core/bloombits: add benchmark * core/bloombits: optimize inserts
* core/types: tests for bloom * core/types: refactored bloom filter for receipts, added tests core/types: replaced old bloom implementation core/types: change interface of bloom add+test * core/types: refactor bloom * core/types: minor tweak on LogsBloom Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
This fixes issues with the protocol handshake and status exchange and adds support for responding to GetBlockHeaders requests.
This makes it accept the "upgrade,keep-alive" header value, which apparently is a thing.
* signer/core: don't mismatch reject and zero accounts, fixes #21674 * signer/core: docs
…#21673) For some reason, using the shared hash causes a cryptographic incompatibility when using Go 1.15. I noticed this during the development of Discovery v5.1 when I added test vector verification. The go library commit that broke this is golang/go@97240d5, but the way we used HKDF is slightly dodgy anyway and it's not a regression.
* core/vm: dedup config check * review feedback: reuse buffer
* eth/downloader: fix data race around the ancientlimit * eth/downloader: initialize the ancientlimit as 0
* trie: polish commit function * trie: fix typo
* imporve some web3-ext apis * Update web3ext.go Co-authored-by: Felix Lange <fjl@twurst.com>
* peer: return localAddr instead of name to prevent spam We currently use the name (which can be freely set by the peer) in several log messages. This enables malicious actors to write spam into your geth log. This commit returns the localAddr instead of the freely settable name. * p2p: reduce usage of peer.Name in warn messages * eth, p2p: use truncated names * Update peer.go Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Felix Lange <fjl@twurst.com>
* miner: exit loop when downloader Done or Failed Following the logic of the comment at the method, this fixes a regression introduced at 7cf56d6 , which would allow external parties to DoS with blocks, preventing mining progress. Signed-off-by: meows <b5c6@protonmail.com> * miner: remove ineff assign (lint) Signed-off-by: meows <b5c6@protonmail.com> * miner: update test re downloader events Signed-off-by: meows <b5c6@protonmail.com> * Revert "miner: remove ineff assign (lint)" This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058. * Revert "miner: exit loop when downloader Done or Failed" This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b. * miner: add test showing imprecise TestMiner Signed-off-by: meows <b5c6@protonmail.com> * miner: fix waitForMiningState precision This helper function would return an affirmation on the first positive match on a desired bool. This was imprecise; it return false positives by not waiting initially for an 'updated' value. This fix causes TestMiner_2 to fail, which is expected. Signed-off-by: meows <b5c6@protonmail.com> * miner: remove TestMiner_2 demonstrating broken test This test demonstrated the imprecision of the test helper function waitForMiningState. This function has been fixed with 6d365c2851, and this test test may now be removed. Signed-off-by: meows <b5c6@protonmail.com> * miner: fix test regarding downloader event/mining expectations See comment for logic. Signed-off-by: meows <b5c6@protonmail.com> * miner: add test describing expectations for downloader/mining events We expect that once the downloader emits a DoneEvent, signaling a successful sync, that subsequent StartEvents are not longer permitted to stop the miner. This prevents a security vulnerability where forced syncs via fake high blocks would stall mining operation. Signed-off-by: meows <b5c6@protonmail.com> * miner: use 'canStop' state to fix downloader event handling - Break downloader event handling into event separating Done and Failed events. We need to treat these cases differently since a DoneEvent should prevent the miner from being stopped on subsequent downloader Start events. - Use canStop state to handle the one-off case when a downloader first succeeds. Signed-off-by: meows <b5c6@protonmail.com> * miner: improve comment wording Signed-off-by: meows <b5c6@protonmail.com> * miner: start mining on downloader events iff not already mining Signed-off-by: meows <b5c6@protonmail.com> * miner: refactor miner update logic w/r/t downloader events This makes mining pause/start logic regarding downloader events more explicit. Instead of eternally handling downloader events after the first done event, the subscription is closed when downloader events are no longer actionable. Signed-off-by: meows <b5c6@protonmail.com> * miner: fix handling downloader events on subcription closed Signed-off-by: meows <b5c6@protonmail.com> * miner: (lint:gosimple) use range over chan instead of for/select Signed-off-by: meows <b5c6@protonmail.com> * miner: refactor update loop to remove race condition The go routine handling the downloader events handling vars in parallel with the parent routine, causing a race condition. This change, though ugly, remove the condition while still allowing the downloader event subscription to be closed when the miner has no further use for it (ie DoneEvent). * miner: alternate fix for miner-flaw Co-authored-by: meows <b5c6@protonmail.com>
* accounts/keystore: add timeout to test to prevent failure on travis The TestWalletNotifications test sporadically fails on travis. This is because we shutdown the event collection before all events are received. Adding a small timeout (10 milliseconds) allows the collector to be scheduled and to consume all pending events before we shut it down. * accounts/keystore: added newlines back in * accounts/keystore: properly fix the walletNotifications test
This change implements the Discovery v5.1 wire protocol and also adds an interactive test suite for this protocol.
- Update generated code (abigen, done with go generate) - Change Unpack to UnpacIntoInterface - Unused dependency (gotest.tools)
Scheusal13
reviewed
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Plan & Analyse
As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.
Build & Test
masterinto this branchAdd any extra changes/tests as comments on this PR.
Extra changes
UnpacktoUnpackIntoInterfaceGo-Ethereum Release: Tupari (v1.9.23)
Release notes
Geth v1.9.23 is a maintenance release containing security fixes. This update is recommended for all users.
Security issues fixed in this release:
Other changes in this release:
account_signGnosisSafeTxAPI method helps with transaction signing using Gnosis Safe (#21593)account_listrequests now work even when when no wallets are present (#21677)Optimizations:
For a full rundown of the changes please consult the Geth 1.9.23 release milestone
As with all our previous releases, you can find the:
ethereum/client-go.Codebase changes assessment
Legend
File Stats: (A) Added, (M) Modified and (R) Removed
Line Stats: (A) Added and (R) Removed
Assessment:
40 Pull Requests
M/A/R
(files changed)
A/R
(lines changed)
ABI explicit difference between Unpack and UnpackIntoInterfaceaccounts/abi(9)accounts/abi/bind(4)contracts/checkpointoracle/contract(2)go.mod(1)mobile(1)tests/fuzzers/abi(1)accounts/abi/reflect_test.go(140)contracts/checkpointoracle/contract/oracle.go(136)accounts/abi/abi.go(120)accounts/abi/unpack_test.go(120)accounts/abi/argument.go(108)mobile: added constructor for big intmobile(1)mobile/big.go(20)core/vm, params: make 2200 in line with speccore/vm(1)params(1)core/vm/gas_table.go(68)params/protocol_params.go(24)eth, core: free pointer from slice after popping element from price heapcore(1)core/tx_list.go(2)internal/web3ext: improve eth_getBlockByNumber and eth_getBlockByHash apiinternal/web3ext(1)internal/web3ext/web3ext.go(12)light: fix wrong description of ChtRequestlight(1)light/odr.go(4)p2p/enode: remove unused codep2p/enode(1)p2p/enode/node.go(42)build: keep geth-sources.jar build result for JavaDocMakefile(1)build(1)Makefile(8)build/ci.go(2)cmd/bootnode,internal/debug: fix some commentscmd/bootnode(1)internal/debug(1)cmd/bootnode/main.go(4)internal/debug/api.go(4)trie: Derivesha with stacktrietrie(5)core(1)core/types(1)eth/downloader(1)eth(1)trie/stacktrie.go(808)trie/stacktrie_test.go(484)trie/encoding_test.go(72)trie/encoding.go(58)core/types/derive_sha.go(36)accounts, signer: implement gnosis safe supportsigner/core(6)cmd/clef(1)common/math(1)signer/core/signed_data_test.go(234)signer/core/gnosis_safe.go(182)cmd/clef/extapi_changelog.md(116)signer/core/signed_data.go(102)common/math/big.go(68)trie: polish committertrie(4)trie/trie_test.go(268)trie/committer.go(236)trie/trie.go(10)trie/hasher.go(8)trie: add Commit-sequence tests for stacktrie committrie(1)trie/trie_test.go(118)core/state/snapshot: stop generator if it hits missing trie nodescore/state/snapshot(2)core/state/snapshot/generate_test.go(380)core/state/snapshot/generate.go(38)cmd/faucet: enable DNS discovery for known networkscmd/faucet(1)cmd/utils(1)cmd/utils/flags.go(24)cmd/faucet/faucet.go(4)params: update goerli testnet bootnodesparams(1)params/bootnodes.go(16)core/bloombits: faster generatorcore/bloombits(2)core/bloombits/generator_test.go(78)core/bloombits/generator.go(46)core/types: optimize bloom filterscore/types(2)core/types/bloom9_test.go(246)core/types/bloom9.go(200)cmd/devp2p/internal/ethtest: update eth test suitecmd/devp2p/internal/ethtest(4)cmd/devp2p/internal/ethtest/testdata(2)cmd/devp2p/internal/ethtest/types.go(476)cmd/devp2p/internal/ethtest/suite.go(334)cmd/devp2p/internal/ethtest/chain_test.go(300)cmd/devp2p/internal/ethtest/chain.go(106)cmd/devp2p/internal/ethtest/testdata/genesis.json(52)node: fix websocket connection header checknode(2)node/rpcstack_test.go(30)node/rpcstack.go(4)signer/core: don't mismatch reject and no accountssigner/core(1)signer/core/api.go(12)p2p/discover: remove use of shared hash instance for key derivationp2p/discover(1)p2p/discover/v5_encoding.go(4)core/vm: dedup config check in markdown loggercore/vm(1)core/vm/logger.go(22)eth/downloader: fix data race around the ancientlimiteth/downloader(1)eth/downloader/downloader.go(10)eth/downloader: cache parent hash instead of recomputingeth/downloader(1)eth/downloader/queue.go(10)core/tx_pool: fix off-by-one errorcore(1)core/tx_pool.go(2)trie: polish commit functiontrie(2)trie/stacktrie.go(46)trie/trie_test.go(10)accounts, consensus, core: fix some typos in commentscore/state(1)accounts(1)accounts/scwallet(1)accounts/usbwallet(1)consensus/clique(1)core/state/state_object.go(12)accounts/accounts.go(4)accounts/scwallet/wallet.go(4)accounts/usbwallet/wallet.go(4)consensus/clique/snapshot_test.go(4)console: fix admin.sleepBlocks() callconsole(1)console/bridge.go(24)all: replace RWMutex with Mutex in places where RLock is not usedeth/downloader(2)accounts/keystore(1)core(1)les(1)miner(1)eth/downloader/downloader_test.go(6)accounts/keystore/file_cache.go(4)core/chain_indexer.go(4)eth/downloader/downloader.go(4)les/txrelay.go(4)consensus/clique: unexport calcDifficulty and improve commentconsensus/clique(1)consensus/clique/clique.go(28)trie: fix flaw in stacktrie pool reusetrie(1)trie/stacktrie.go(4)internal/web3ext: improve some web3 apisinternal/web3ext(1)internal/web3ext/web3ext.go(26)eth, p2p: use truncated namesp2p(2)p2p/peer.go(26)p2p/server.go(18)cmd/geth, cmd/utils: fixed flags namecmd/geth(2)cmd/utils(1)cmd/utils/flags.go(24)cmd/geth/main.go(8)cmd/geth/usage.go(8)miner: don't interrupt mining after successful syncminer(2)miner/miner_test.go(134)miner/miner.go(46)accounts/keystore: add timeout to test to prevent failure on travisaccounts/keystore(1)accounts/keystore/keystore_test.go(8)params: update CHTsparams(1)params/config.go(64)miner: set etherbase even if mining isn't possible at the momentminer(2)miner/miner_test.go(44)miner/miner.go(4)p2p/discover: implement v5.1 wire protocolp2p/discover(7)p2p/discover/v5wire(6)p2p/discover/v5wire/testdata(4)cmd/devp2p(3)cmd/devp2p/internal/v5test(2)internal/utesting(1)p2p/netutil(1)p2p/discover/v5_encoding.go(1318)p2p/discover/v5wire/encoding.go(1296)p2p/discover/v5wire/encoding_test.go(1272)p2p/discover/v5_udp.go(922)cmd/devp2p/internal/v5test/discv5tests.go(754)115 Changed files
p2p/discover/v5_encoding.go#21647
p2p/discover/v5wire/encoding.gop2p/discover/v5wire/encoding_test.gop2p/discover/v5_udp.gotrie/stacktrie.go#21692
#21699
cmd/devp2p/internal/v5test/discv5tests.gop2p/discover/v5_encoding_test.gop2p/discover/v5_udp_test.gocmd/devp2p/internal/v5test/framework.gop2p/discover/v5wire/msg.gotrie/stacktrie_test.gocmd/devp2p/internal/ethtest/types.gotrie/trie_test.go#21692
#21643
core/state/snapshot/generate_test.gop2p/discover/v5wire/crypto.gocmd/devp2p/internal/ethtest/suite.gocmd/devp2p/internal/ethtest/chain_test.gop2p/discover/v5wire/crypto_test.gocore/types/bloom9_test.gotrie/committer.gosigner/core/signed_data_test.gocore/types/bloom9.gosigner/core/gnosis_safe.gominer/miner_test.go#21707
cmd/devp2p/README.mdp2p/discover/v5wire/session.goaccounts/abi/reflect_test.gocontracts/checkpointoracle/contract/oracle.goaccounts/abi/unpack_test.goaccounts/abi/abi.gocmd/clef/extapi_changelog.mdaccounts/abi/argument.gocmd/devp2p/internal/ethtest/chain.gosigner/core/signed_data.goaccounts/abi/packing_test.gocore/bloombits/generator_test.gosigner/core/api.go#21593
trie/encoding_test.gocmd/devp2p/discv5cmd.goaccounts/abi/bind/template.gocore/vm/gas_table.gocommon/math/big.goparams/config.gotrie/encoding.gop2p/discover/v5wire/testdata/v5.1-ping-handshake-enr.txtcmd/devp2p/internal/ethtest/testdata/genesis.jsonaccounts/abi/reflect.gointernal/utesting/utesting.gominer/miner.go#21707
cmd/utils/flags.go#21700
p2p/discover/v5wire/testdata/v5.1-ping-handshake.txtcore/bloombits/generator.goaccounts/abi/event_test.gosigner/core/auditlog.gop2p/enode/node.gocore/state/snapshot/generate.gointernal/web3ext/web3ext.go#21639
mobile/bind.gocore/types/derive_sha.goaccounts/abi/abi_test.gop2p/discover/v4_lookup_test.goaccounts/abi/bind/base.gonode/rpcstack_test.goconsensus/clique/clique.goaccounts/abi/pack_test.gop2p/peer.goparams/protocol_params.gocmd/devp2p/discv4cmd.goconsole/bridge.gocore/vm/logger.gop2p/discover/v5wire/testdata/v5.1-ping-message.txtmobile/big.gop2p/server.goeth/downloader/queue.go#21678
p2p/discover/v5wire/testdata/v5.1-whoareyou.txtparams/bootnodes.gop2p/netutil/error.gotrie/database.gosigner/core/cliui.goaccounts/abi/bind/base_test.goeth/downloader/downloader.go#21622
core/state/state_object.gop2p/discover/table_util_test.gop2p/discover/node.gotrie/trie.goaccounts/abi/bind/bind_test.gocore/block_validator.goaccounts/keystore/keystore_test.gotrie/hasher.gocmd/geth/main.gotests/fuzzers/abi/abifuzzer.goMakefilecmd/geth/usage.goeth/downloader/downloader_test.goparams/version.goles/txrelay.gocmd/faucet/faucet.gocontracts/checkpointoracle/contract/oracle.solaccounts/accounts.gogo.modaccounts/usbwallet/wallet.gointernal/debug/api.gonode/rpcstack.gocore/chain_indexer.goaccounts/scwallet/wallet.goaccounts/keystore/file_cache.goeth/handler.gominer/unconfirmed.gocmd/bootnode/main.goconsensus/clique/snapshot_test.golight/odr.gocore/tx_pool.gobuild/ci.gocore/tx_list.gocmd/devp2p/internal/ethtest/testdata/chain.rlp.gz