-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new rules package_ntp_removed, package_timesyncd_removed #11831
Add new rules package_ntp_removed, package_timesyncd_removed #11831
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Added red-hatters and suse maintainers as this new rule might be relevant for them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpurg you will need to add these rules to the correct component
files. package_ntp_removed
should go in components/ntp.yml
. package_timesyncd_removed
should go in components/systemd.yml
.
0ebdd79
to
a4437c4
Compare
@Mab879 thanks for catching that. I wasn't aware this was a requirement. I added |
/packit retest-failed |
1 similar comment
/packit retest-failed |
/packit build |
@mpurg I would try rebasing on master to fix the testing farm errors. |
a4437c4
to
fd56f6b
Compare
@Mab879 done |
That seems to fix it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
fd56f6b
to
2e4e81f
Compare
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/packit build |
Added new rules for removing packages ntp and systemd-timesyncd. package_ntp_removed - satisfies UBTU-22-215025 - based on package_ntp_installed package_timesyncd_removed - satisfies UBTU-22-215020 - based on package_timesyncd_installed
2e4e81f
to
08ec2b8
Compare
Code Climate has analyzed commit 08ec2b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/packit build |
Description: